-
Notifications
You must be signed in to change notification settings - Fork 170
PR from E2552 to E2557 #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deekshithanantha
wants to merge
17
commits into
expertiza:main
Choose a base branch
from
deekshithanantha:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we updated the puma version
credits to csingha - Introduced role hierarchy creation for users (Super Administrator, Administrator, Instructor, Teaching Assistant, Student). - Streamlined user creation process for instructors and students. - Added error handling for database seeding to provide clearer messages. - Improved code organization and readability by removing redundant comments and restructuring the flow.
commit f608218 Author: dmpatel3 <[email protected]> Date: Wed Apr 16 22:13:20 2025 -0400 Renamed find_team_users() to find_project_topic_team_users() and adjusted SignedUpTeam tests accordingly commit 615c2b7 Author: smiti <[email protected]> Date: Thu Apr 17 06:37:54 2025 +0530 add new tests and comments for project_topic and signed_up_team. commit 54656ae Author: smiti <[email protected]> Date: Wed Apr 16 10:41:57 2025 +0530 add new function in signed up team and its tests. commit 4b4eb90 Merge: a351623 0e067e0 Author: Adithya Srinivasan <[email protected]> Date: Mon Mar 24 17:07:24 2025 -0400 Merge branch 'main' of https://github.com/RandomOscillations/reimplementation-back-end commit a351623 Author: Adithya Srinivasan <[email protected]> Date: Mon Mar 24 17:05:06 2025 -0400 Added JSON parsing in project_topic_controller_spec.rb commit 0e067e0 Author: smiti <[email protected]> Date: Tue Mar 25 01:41:31 2025 +0530 fix the code commit 0faeb33 Author: smiti <[email protected]> Date: Mon Mar 24 09:07:34 2025 +0530 fixed the routing test file commit f6a4774 Author: dmpatel3 <[email protected]> Date: Sun Mar 23 21:54:21 2025 -0400 Added and modified tests for the ProjectTopic controller commit acecf6b Author: smiti <[email protected]> Date: Mon Mar 24 04:58:41 2025 +0530 made necessary changes commit 2793616 Author: smiti <[email protected]> Date: Sat Mar 22 05:20:54 2025 +0530 add tests and code for model commit 8ed7a4a Author: smiti <[email protected]> Date: Sat Mar 22 05:20:37 2025 +0530 add tests commit 6c0dbec Author: dmpatel3 <[email protected]> Date: Thu Mar 20 18:17:26 2025 -0400 Refactored remaining SignUpTopic-related instances across the project to ProjectTopic-related instances commit c242e16 Author: smiti <[email protected]> Date: Thu Mar 20 05:05:37 2025 +0530 refactored the project_topic model. commit 39df8eb Author: smiti <[email protected]> Date: Wed Mar 19 07:31:00 2025 +0530 Added migration file and renamed sign_up_topic to project_topic
…tency - Updated `signup_team` method to `sign_team_up` in ProjectTopic for improved readability. - Adjusted references in SignedUpTeam to call the renamed method. - Fixed DRY violation. - Commented out fixture path in RSpec configuration to resolve errors. - Updated tests to reflect method name changes and ensure proper functionality.
- Removed the API namespace from ProjectTopicsController for simplified routing. - Updated the index action comment to reflect the new endpoint structure.
- Updated ProjectTopicsController to include calculated fields in the response for project topics. - Added new methods in SignedUpTeamsController for dropping topics and teams from topics, with appropriate error handling and responses. - Refactored SignedUpTeam model to streamline the creation and deletion of signed up teams. - Updated routes to include new endpoints for dropping topics and teams. - Enhanced db/seeds.rb to create sample project topics and a test student user for easier testing.
…oved functionality - Updated ProjectTopicsController to utilize new model methods for creating, updating, and deleting project topics, enhancing code clarity and maintainability. - Refactored SignedUpTeamsController to streamline team signup and topic management processes, incorporating new business logic methods from the SignedUpTeam model. - Enhanced error handling and response messages for better API usability. - Added JSON serialization for project topics to include computed data in responses, reducing frontend processing needs.
Generated by 🚫 Danger |
…ment functionality - Added methods to get a user's team for a specific assignment and ensure a team exists for the assignment, enhancing the signup process. - Updated the sign-up logic to utilize the new methods for better handling of team assignments. - Modified the seeds file to create TeamsParticipant records, streamlining the assignment of students to teams.
|
🚨 RSpec Tests Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.